__init__/fix: the app will shutdown if wsgi fail. #2193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constantin1489
commented
Feb 15, 2024
| # port conflicts and shutdown. | ||
| PORT=5000 python changedetection.py -d /datastore' || true & | ||
| sleep 7 | ||
| docker ps -a |
There was a problem hiding this comment.
sleep is a little longer. the reason will be appeared in docker ps -a
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Constantin1489
commented
Feb 15, 2024
Constantin1489
commented
Feb 15, 2024
changedetectionio/__init__.py
Outdated
| app.config.exit.set() | ||
| datastore.stop_thread = True | ||
| while len(threading.enumerate()) > 1: | ||
| time.sleep(1) |
There was a problem hiding this comment.
#app.config.exit.set()
#datastore.stop_thread = True
while len(threading.enumerate()) > 1:
print(threading.enumerate())
shows the reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this looks weird but refer to another apps's docker-compse, they start the DB first(https://github.com/Leantime/docker-leantime/blob/c35f5a72670d59efa7b2c0e88fca19ff4c11d8ae/docker-compose.yml#L30, https://github.com/minhng92/odoo-16-docker-compose/blob/c28f67b805413b7ebe7c8c4a91c1db38b67e2f83/docker-compose.yml#L18) and then the app.
Because the CD is standalone, the DB part started before the
wsgi... So... then port conflict happens we need to stop the threads..closes #2177