Skip to content

Commit

Permalink
ci: pin isort instead of virtualenv
Browse files Browse the repository at this point in the history
Following along on PyCQA/isort#1874 ,
seems like this is the "real" fix.
  • Loading branch information
dhalperi committed Dec 28, 2021
1 parent 905865a commit 0701ac0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .buildkite/pipeline.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ cat <<EOF
command:
- "python3 -m virtualenv .venv"
- ". .venv/bin/activate"
# https://github.com/pypa/virtualenv/issues/2257
- "python3 -m pip install pre-commit 'virtualenv<20.11.0'"
- "python3 -m pip install pre-commit"
- "pre-commit run --all-files"
plugins:
- docker#${BATFISH_DOCKER_PLUGIN_VERSION}:
Expand Down
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ repos:
- id: black

- repo: https://github.com/pycqa/isort
rev: 5.8.0
# Switch to release from PR when https://github.com/PyCQA/isort/pull/1875 is merged
rev: 5e1a36521f834769b2b6dfd6466e792abd435dec
hooks:
- id: isort
args: ["--profile", "black", "--filter-files"]
Expand Down

0 comments on commit 0701ac0

Please sign in to comment.