refactor: remove typeof operator for undefined checks

dherault · Oct 15, 2022 · 312d4f0 · 312d4f0
1 parent 9a07736
commit 312d4f0
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/src/events/http/HttpServer.js b/src/events/http/HttpServer.js
@@ -459,12 +459,12 @@ export default class HttpServer {
 
       // default request template to '' if we don't have a definition pushed in from serverless or endpoint
       const requestTemplate =
-        typeof requestTemplates !== 'undefined' && integration === 'AWS'
+        requestTemplates !== undefined && integration === 'AWS'
           ? requestTemplates[contentType]
           : ''
 
       const schemas =
-        typeof endpoint?.request?.schemas !== 'undefined'
+        endpoint?.request?.schemas !== undefined
           ? endpoint.request.schemas[contentType]
           : ''
 
@@ -647,10 +647,7 @@ export default class HttpServer {
                 headerValue = valueArray[3]
                   ? jsonPath(result, valueArray.slice(3).join('.'))
                   : result
-                if (
-                  typeof headerValue === 'undefined' ||
-                  headerValue === null
-                ) {
+                if (headerValue === undefined || headerValue === null) {
                   headerValue = ''
                 } else {
                   headerValue = headerValue.toString()
@@ -857,7 +854,7 @@ export default class HttpServer {
 
         if (typeof result === 'string') {
           response.source = stringify(result)
-        } else if (result && typeof result.body !== 'undefined') {
+        } else if (result && result.body !== undefined) {
           if (result.isBase64Encoded) {
             response.encoding = 'binary'
             response.source = Buffer.from(result.body, 'base64')

diff --git a/src/events/http/lambda-events/LambdaProxyIntegrationEvent.js b/src/events/http/lambda-events/LambdaProxyIntegrationEvent.js
@@ -104,7 +104,7 @@ export default class LambdaProxyIntegrationEvent {
       ) {
         headers['Content-Type'] = 'application/json'
       }
-    } else if (typeof body === 'undefined' || body === '') {
+    } else if (body === undefined || body === '') {
       body = null
     }
 

diff --git a/src/events/http/lambda-events/LambdaProxyIntegrationEventV2.js b/src/events/http/lambda-events/LambdaProxyIntegrationEventV2.js
@@ -87,7 +87,7 @@ export default class LambdaProxyIntegrationEventV2 {
       if (!headers['content-type']) {
         headers['content-type'] = 'application/json'
       }
-    } else if (typeof body === 'undefined' || body === '') {
+    } else if (body === undefined || body === '') {
       body = null
     }
 

diff --git a/src/lambda/routes/invocations/invocationsRoute.js b/src/lambda/routes/invocations/invocationsRoute.js
@@ -43,7 +43,7 @@ export default function invocationsRoute(lambda, options) {
       let statusCode = 200
       let functionError = null
       if (invokeResults) {
-        const isPayloadDefined = typeof invokeResults.Payload !== 'undefined'
+        const isPayloadDefined = invokeResults.Payload !== undefined
         resultPayload = isPayloadDefined ? invokeResults.Payload : ''
         statusCode = invokeResults.StatusCode || 200
         functionError = invokeResults.FunctionError || null