Skip to content

Commit

Permalink
Rename getUniqueId to createUniqueId
Browse files Browse the repository at this point in the history
  • Loading branch information
dnalborczyk committed Jul 3, 2019
1 parent b9b1d72 commit c3fcc4c
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 19 deletions.
4 changes: 2 additions & 2 deletions src/ApiGateway.js
Expand Up @@ -15,7 +15,7 @@ const createAuthScheme = require('./createAuthScheme');
const functionHelper = require('./functionHelper');
const Endpoint = require('./Endpoint');
const parseResources = require('./parseResources');
const { detectEncoding, getUniqueId } = require('./utils');
const { detectEncoding, createUniqueId } = require('./utils');
const authFunctionNameExtractor = require('./authFunctionNameExtractor');
const requestBodyValidator = require('./requestBodyValidator');

Expand Down Expand Up @@ -345,7 +345,7 @@ module.exports = class ApiGateway {
}
}
// Shared mutable state is the root of all evil they say
const requestId = getUniqueId();
const requestId = createUniqueId();
this.requests[requestId] = { done: false };
this.currentRequestId = requestId;

Expand Down
4 changes: 2 additions & 2 deletions src/ApiGatewayWebSocket.js
Expand Up @@ -8,7 +8,7 @@ const hapiPluginWebsocket = require('hapi-plugin-websocket');
const debugLog = require('./debugLog');
const createLambdaContext = require('./createLambdaContext');
const functionHelper = require('./functionHelper');
const { getUniqueId } = require('./utils');
const { createUniqueId } = require('./utils');
const authFunctionNameExtractor = require('./authFunctionNameExtractor');
const wsHelpers = require('./websocketHelpers');

Expand Down Expand Up @@ -154,7 +154,7 @@ module.exports = class ApiGatewayWebSocket {
initially: false,
connect: ({ ws, req }) => {
const queryStringParameters = parseQuery(req.url);
const connection = { connectionId:getUniqueId(), connectionTime:Date.now() };
const connection = { connectionId:createUniqueId(), connectionTime:Date.now() };

debugLog(`connect:${connection.connectionId}`);

Expand Down
4 changes: 2 additions & 2 deletions src/createLambdaContext.js
@@ -1,6 +1,6 @@
'use strict';

const { getUniqueId } = require('./utils');
const { createUniqueId } = require('./utils');

// https://docs.aws.amazon.com/lambda/latest/dg/limits.html
// default function timeout in seconds
Expand All @@ -26,7 +26,7 @@ module.exports = function createLambdaContext(fun, provider, cb) {
getRemainingTimeInMillis: () => endTime - new Date().getTime(),

// properties
awsRequestId: `offline_awsRequestId_${getUniqueId()}`,
awsRequestId: `offline_awsRequestId_${createUniqueId()}`,
clientContext: {},
functionName,
functionVersion: `offline_functionVersion_for_${functionName}`,
Expand Down
4 changes: 2 additions & 2 deletions src/createLambdaProxyContext.js
Expand Up @@ -5,7 +5,7 @@ const {
normalizeMultiValueQuery,
normalizeQuery,
nullIfEmpty,
getUniqueId,
createUniqueId,
} = require('./utils');

/*
Expand Down Expand Up @@ -79,7 +79,7 @@ module.exports = function createLambdaProxyContext(request, options, stageVariab
resourceId: 'offlineContext_resourceId',
apiId: 'offlineContext_apiId',
stage: options.stage,
requestId: `offlineContext_requestId_${getUniqueId()}`,
requestId: `offlineContext_requestId_${createUniqueId()}`,
identity: {
cognitoIdentityPoolId: process.env.SLS_COGNITO_IDENTITY_POOL_ID || 'offlineContext_cognitoIdentityPoolId',
accountId: process.env.SLS_ACCOUNT_ID || 'offlineContext_accountId',
Expand Down
4 changes: 2 additions & 2 deletions src/createVelocityContext.js
Expand Up @@ -2,7 +2,7 @@

const jsEscapeString = require('js-string-escape');
const { decode } = require('jsonwebtoken');
const { isPlainObject, getUniqueId } = require('./utils');
const { isPlainObject, createUniqueId } = require('./utils');
const jsonPath = require('./jsonPath');

function escapeJavaScript(x) {
Expand Down Expand Up @@ -66,7 +66,7 @@ module.exports = function createVelocityContext(request, options, payload) {
userAgent: request.headers['user-agent'] || '',
userArn: 'offlineContext_userArn',
},
requestId: `offlineContext_requestId_${getUniqueId()}`,
requestId: `offlineContext_requestId_${createUniqueId()}`,
resourceId: 'offlineContext_resourceId',
resourcePath: request.route.path,
stage: options.stage,
Expand Down
4 changes: 2 additions & 2 deletions src/functionHelper.js
Expand Up @@ -4,7 +4,7 @@ const { fork, spawn } = require('child_process');
const path = require('path');
const trimNewlines = require('trim-newlines');
const debugLog = require('./debugLog');
const { getUniqueId } = require('./utils');
const { createUniqueId } = require('./utils');

const handlerCache = {};
const messageCallbacks = {};
Expand Down Expand Up @@ -150,7 +150,7 @@ module.exports = {
}

return (event, context, done) => {
const id = getUniqueId();
const id = createUniqueId();
messageCallbacks[id] = done;
handlerContext.inflight.add(id);
handlerContext.process.send(Object.assign({}, funOptions, { id, event, context }));
Expand Down
2 changes: 1 addition & 1 deletion src/utils.js
Expand Up @@ -43,7 +43,7 @@ module.exports = {
return createHash('md5').digest('hex');
},

getUniqueId() {
createUniqueId() {
return cuid();
},
};
12 changes: 6 additions & 6 deletions src/websocketHelpers.js
@@ -1,5 +1,5 @@
const { DateTime } = require('luxon');
const { getUniqueId } = require('./utils');
const { createUniqueId } = require('./utils');

// TODO this should be probably moved to utils, and combined with other header
// functions and utilities
Expand Down Expand Up @@ -34,7 +34,7 @@ const createRequestContext = (action, eventType, connection) => {
connectionId:connection.connectionId,
domainName: 'localhost',
eventType,
extendedRequestId: `${getUniqueId()}`,
extendedRequestId: `${createUniqueId()}`,
identity: {
accountId: null,
accessKey: null,
Expand All @@ -50,8 +50,8 @@ const createRequestContext = (action, eventType, connection) => {
userArn: null,
},
messageDirection: 'IN',
messageId: `${getUniqueId()}`,
requestId: `${getUniqueId()}`,
messageId: `${createUniqueId()}`,
requestId: `${createUniqueId()}`,
requestTime: formatToClfTime(now),
requestTimeEpoch: now.getTime(),
routeKey: action,
Expand All @@ -76,9 +76,9 @@ exports.createConnectEvent = (action, eventType, connection, options) => {
const headers = {
Host: 'localhost',
'Sec-WebSocket-Extensions': 'permessage-deflate; client_max_window_bits',
'Sec-WebSocket-Key': `${getUniqueId()}`,
'Sec-WebSocket-Key': `${createUniqueId()}`,
'Sec-WebSocket-Version': '13',
'X-Amzn-Trace-Id': `Root=${getUniqueId()}`,
'X-Amzn-Trace-Id': `Root=${createUniqueId()}`,
'X-Forwarded-For': '127.0.0.1',
'X-Forwarded-Port': `${options.port + 1}`,
'X-Forwarded-Proto': `http${options.httpsProtocol ? 's' : ''}`,
Expand Down

0 comments on commit c3fcc4c

Please sign in to comment.