Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1018

Closed
wants to merge 1 commit into from
Closed

Conversation

dustinsgoodman
Copy link

Removing comments regarding the process.env.IS_OFFLINE variable as it has been removed by the plugin in the v6 alpha changes. See #768 (comment) for more details.

Removing comments regarding the process.env.IS_OFFLINE variable as it has been removed by the plugin in the v6 alpha changes. See dherault#768 (comment) for more details.
@dherault
Copy link
Owner

Hi @dustinsgoodman, the env variable is back! That's why it has been added to the readme. Please update to the latest version to take advantage of it.

@dherault dherault closed this Jun 19, 2020
@dustinsgoodman
Copy link
Author

Hey @dherault, awesome that it's back but the flip flopping is rather annoying. Because this has been added and removed and the changelog is lacking, I rolled my own implementation and the documentation around this. It would be great if you could document why this was removed and readded. I just found it but it's buried in your commit history and was not obvious.

@dherault
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants