Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Resolve Fn::Join in environment variables #1020

Closed
wants to merge 1 commit into from
Closed

feat: Resolve Fn::Join in environment variables #1020

wants to merge 1 commit into from

Conversation

chardos
Copy link
Collaborator

@chardos chardos commented Jun 15, 2020

Purpose

Currently, Fn::Join is not being resolved correctly in environment variables. This PR uses javascript's Array.join to correctly resolve such values.

@chardos chardos linked an issue Jun 15, 2020 that may be closed by this pull request
Using Fn::Join resolves to [Object Object] #1013
Open
@chardos
Copy link
Collaborator Author

chardos commented Jun 15, 2020

Closing until tests resolved

@chardos chardos closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Fn::Join resolves to [Object Object]
1 participant
@chardos