Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined environment variables in resolveJoins #1047

Merged
merged 4 commits into from
Aug 26, 2020

Commits on Jul 19, 2020

  1. Handle undefined environment variables in resolveJoins

    Fixes the following exception:
    ```
    Debug: internal, implementation, error
        TypeError: Cannot read property 'Fn::Join' of undefined
        at /Users/alexhayton/personal/stablemaster/lambda/node_modules/serverless-offline/dist/utils/resolveJoins.js:17:28
        at Array.forEach (<anonymous>)
        at resolveJoins (/Users/alexhayton/personal/stablemaster/lambda/node_modules/serverless-offline/dist/utils/resolveJoins.js:15:28)
        at new LambdaFunction (/Users/alexhayton/personal/stablemaster/lambda/node_modules/serverless-offline/dist/lambda/LambdaFunction.js:154:56)
        at LambdaFunctionPool.get (/Users/alexhayton/personal/stablemaster/lambda/node_modules/serverless-offline/dist/lambda/LambdaFunctionPool.js:93:24)
        at Lambda.get (/Users/alexhayton/personal/stablemaster/lambda/node_modules/serverless-offline/dist/lambda/Lambda.js:60:88)
        at hapiHandler (/Users/alexhayton/personal/stablemaster/lambda/node_modules/serverless-offline/dist/events/http/HttpServer.js:511:82)
        at module.exports.internals.Manager.execute (/Users/alexhayton/personal/stablemaster/lambda/node_modules/@hapi/hapi/lib/toolkit.js:41:33)
        at Object.internals.handler (/Users/alexhayton/personal/stablemaster/lambda/node_modules/@hapi/hapi/lib/handler.js:46:48)
        at exports.execute (/Users/alexhayton/personal/stablemaster/lambda/node_modules/@hapi/hapi/lib/handler.js:31:36)
        at Request._lifecycle (/Users/alexhayton/personal/stablemaster/lambda/node_modules/@hapi/hapi/lib/request.js:312:68)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)
        at Request._execute (/Users/alexhayton/personal/stablemaster/lambda/node_modules/@hapi/hapi/lib/request.js:221:9)
    ```
    AlexHayton committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    d25a45d View commit details
    Browse the repository at this point in the history
  2. Fix lint issues

    AlexHayton committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    ff5bdf3 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2020

  1. Configuration menu
    Copy the full SHA
    2e6f593 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a273e0e View commit details
    Browse the repository at this point in the history