Issue #931 fix for not allowing caching

[dl748]

Fix for Issue #931 (I tested it out with the webpack plugin to verify)

Added module clear-module, to remove the module that the handler is in, from cache, from every request. Caching can be turned back on using "allowCache" = true in the configuration options

custom:
  serverless-offline:
    allowCache: true

I think the options should be passed to every runner, but it seems some options are nitpicked from the options and passed into the runners. I did the same for consistancy.

[lqueryvg]

Looks good !
What's needed to get this merged ?

[dl748]

@dherault any issues with the PR?

[dherault]

@dl748 not at all, thanks for the PR, I'm taking a look

[dherault]

Looks good, maybe make it an option ?

[dl748]

@dherault isn't it an option? Thats what allowCache: true does ?

[jacklp]

please can we have hot reloading so I can upgrade serverless-offline from 5.12

[lqueryvg]

@dherault it looks like this PR delivers an option which makes this configurable.
(As @dl748's last comment said.)
So can this be merged ?

[stephledev]

I guess it's debatable if the default for allowCache should be true to align with the existing behaviour or false, so people don't have to actively opt-out (which the majority probably wants). Otherwise looks good.

[dl748]

@stephledev I would think as a tool used mainly for developers, the default should be cache is off.

[dherault]

Hi @dl748 ,
I like this PR that solves a big issue,
Can you please add some documentation and option help?
Thanks,

[dl748]

@dherault Updated, unless you want more documentation and cli information than that.

[dherault]

Thanks! v6.7.0!

[dl748]

@dherault this should fix issue #1027 as well, or any ticket involving cached code or hot reloading not working as this PR will uncache the require before reloading.

[jer-sen]

@dl748 I face an error with allowCache: false when calling a lambda via an HTTP request: Failure: Cannot read property 'defineService' of undefined
No error with allowCache: true.
Any idea ?

[dl748]

@jer-sen, i'd have to see your specific code, most likely you, or a package you are using is, using global variables.

[okarlsson]

@dl748 @dherault

This PR made my app start crashing when running with Serverless offline. Might be some combination with serverless-webpack.

Everything works when I set the allowCache flag to true

plugins:

plugins:
  - serverless-webpack
  - serverless-dynamodb-local
  - serverless-offline

Some of the stacktrace:

TypeError: argument must be an instance of Prompt
    at Array.addPrompt [as add] (/node_modules/oidc-provider/lib/helpers/interaction_policy/index.js:34:13)
    at base (/node_modules/oidc-provider/lib/helpers/interaction_policy/index.js:40:11)
    at getDefaults (/node_modules/oidc-provider/lib/helpers/defaults.js:2214:15)
    at Object.<anonymous> (/node_modules/oidc-provider/lib/helpers/request.js:6:46)

[jer-sen]

@dl748 yes I'm using Apollo Server and a MongoDB persistent connection with callbackWaitsForEmptyEventLoop = false
Anything wrong ?

[raymond-w-ko]

I am also having issues with reloading.

If useCache: false then my node ClojureScript project crashes, but this can sort of be waved off being niche.

However, more importantly, this crashes any normal JS module with const AWS = require("aws-sdk") which makes development painful and negates the purpose.

Is there a way to prevent reloading stuff in a project's node_modules/* ?