Protect against undefined env vars when resolving joins #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running sls offline on version 6.5, i came across a somewhat cryptic error:
```
Debug: internal, implementation, error
TypeError: Cannot read property 'Fn::Join' of undefined
at my/path/node_modules/serverless-offline/dist/utils/resolveJoins.js:18:28
at Array.forEach (<anonymous>)
at resolveJoins (my/path/node_modules/serverless-offline/dist/utils/resolveJoins.js:15:28)
at new LambdaFunction (my/path/node_modules/serverless-offline/dist/lambda/LambdaFunction.js:154:56)
at LambdaFunctionPool.get (my/path/node_modules/serverless-offline/dist/lambda/LambdaFunctionPool.js:93:24)
at Lambda.get (my/path/node_modules/serverless-offline/dist/lambda/Lambda.js:60:88)
at hapiHandler (my/path/node_modules/serverless-offline/dist/events/http/HttpServer.js:511:82)
at module.exports.internals.Manager.execute (my/path/node_modules/@hapi/hapi/lib/toolkit.js:41:33)
at Object.internals.handler (my/path/node_modules/@hapi/hapi/lib/handler.js:46:48)
at exports.execute (my/path/node_modules/@hapi/hapi/lib/handler.js:31:36)
at Request._lifecycle (my/path/node_modules/@hapi/hapi/lib/request.js:312:68)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at Request._execute (my/path/node_modules/@hapi/hapi/lib/request.js:221:9)
```
Since this project doesn't use the join intrinsic function, the error wasn't particularly helpful in determining the problem.
After a bit of search, I found the cause in [this PR](dherault#1032).
The problem is that, if an environment variable is `undefined`, an exception is raised.
A better approach might be to either ignore undefined env vars or log them with a warning. I chose the former right now but am open to change the code as needed.
|
oops :D Feel free to merge the one that came first, I'll close mine. |
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running sls offline on version 6.5, i came across a somewhat cryptic error:
Since my project doesn't use the join intrinsic function, the error wasn't particularly helpful in determining the problem.
After a bit of search, I found the cause in this PR.
The problem is that, if an environment variable is
undefined, an exception is raised.A better approach might be to either ignore undefined env vars or log them with a warning. I chose the former right now but am open to change the code as needed.