New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add '--noStripTrailingSlashInUrl' option #1178
Conversation
768cf21
to
0afd09e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @grakic - it looks great overall, I just have one small comment and we should be good to go 🙌
0afd09e
to
e9695ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup and confirmation @grakic 👍
Description
Add
--noStripTrailingSlashInUrl
option passing ending slash to Lambda event.Motivation and Context
We have Lambda responding on HTTP event having
/{any+}
path. Currently it is not possible to receive trailing slash in the requested event path. Both/dev/hello
and/dev/hello/
are sent to Lambda as/dev/hello
.Extra option allows event to be set with a trailing slash and allows request to be sent to Lambda with a trailing slash.