Never remove cached node_modules or binary modules #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dl748
changed the title
dl748
changed the title
|
Can we get this one merged into SLS offline? |
|
I can confirm that we've been using this fork for months, works like a charm 💯 |
|
Yep, problem is it's now behind master ... Be great if someone from the SLS team can approve this! @dherault ? |
|
Well rebasing didn't work, now I lost those changes. |
dl748
force-pushed
the
do_not_uncache_node_modules
branch
from
a6ee025
to
52d1efd
Compare
|
Hey @dl748 - it looks good but it's marked as draft - is it ready for a re-review? |
|
Thanks, @dl748, welcome to the club! |
|
Published in v8.6.0 (in a few hours) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding node_modules check to orphan unloading.
Motivation and Context
if the module in question included a binary plugin, this can cause problems when reloading. We should probably never unload a node_modules package and require the developer to restart if they update or change them. This will force any code outside of node_modules to reload which I think is acceptable, however, if the developer has their OWN binary plugin, this could still be an issue.
How Has This Been Tested?
Included a binary module into the handler that is only used there and called the handler more than once
Screenshots (if appropriate):