fix: Child processes are cleaned up when useChildProcesses is used
#1234
Conversation
|
This could not have come at a better time for me. I was able to test this via and have confirmed this fix indeed works. My system is no longer running out of memory. @dherault Can we get this merged and released? |
| @@ -1,7 +1,7 @@ | |||
| import { resolve } from 'path' | |||
| import path from 'path' | |||
There was a problem hiding this comment.
Do you still need to pull in everything from path here?
There was a problem hiding this comment.
Yes, I changed this because according to the eslint rules an adavetence was launched with the resolve of the promise
It doesn't seem like good practice to me to leave the promise resolution under another name, so import the 'path' and don't destructure the object.
pgrzesik
changed the title
useChildProcesses is used
|
@pgrzesik Could a new release be made, which includes this fix please? |
|
Sure @jaska120 - it just has been released with |
Description
When using useChildProcesses: true, child processes are killed when they finish their execution
Motivation and Context
#1105
How Has This Been Tested?
In the latest version of serverless-offline, using the v12.20.1 version of node and using the task manager, I was able to verify that when the invocation of the function finishes it closes it correctly
I wanted to do unit tests for this but I really don't know what they would be like