fix: async behaviour #1451
Open
fix: async behaviour #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix/async-behaviour
saileshkotha
force-pushed
the
fix/async-behaviour
branch
from
ef56002
to
2793f38
Compare
dnalborczyk
force-pushed
the
master
branch
2 times, most recently
from
d5ea86d
to
22fd667
Compare
dnalborczyk
force-pushed
the
master
branch
2 times, most recently
from
fdd1699
to
51a30e9
Compare
|
@dherault Can you please approve the running workflow? We fixed tests in the current branch. We need the async behavior in our projects. |
|
close/re-open in order to run ci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed logic where async changes the integration to AWS
Added logic to ignore the result of lambda and return a 200
Added body parsing (it parses both application/x-www-form-urlencoded and application/json).
Motivation and Context
https://www.serverless.com/framework/docs/providers/aws/events/apigateway#using-asynchronous-integration
Fixes the behavior of adding the async option to HTTP events.
When async is added, the API Gateway should auto-respond with a 200 and then invoke the lambda asynchronously with the same event as a regular lambda proxy event as described in the docs above.
How Has This Been Tested?
Unit Test
Running Locally