added json override option to response body #1621
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added an option for allowing json objects in the api response body, reason is Aws allows this functionality. ApiGateway doesnt restrict to only string anymore.
Motivation and Context
How Has This Been Tested?
without the allowJsonInBody nothing changes, you still receive the
by adding the option allowJsonInBody: true in serverless.yml under serverless-offline you can now pass json objects in the response body without the need to JSON.stringify() the contents.
following the instructions on the contributing.md doc i added the custom plugin into my serverless project and then tested without the newly created option allowJsonInBody and the error remains the same, then adding in the option allowJsonInBody i now see the api response as aws does.
tests were manual the code change is a boolean check for allowJsonInBody and if its true we do not throw the error but give the respone.
all existing tests passed locally.
Screenshots (if appropriate):