feat: Adding handling for multiple identitySource headers in the REST API. #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-z
approved these changes
Jul 26, 2023
|
Tested these changes locally as well and it works well, accepting multiple values in |
|
@dherault Can you please have a look? |
|
👍 |
|
close/re-open in order to run ci. |
dnalborczyk
changed the title
|
thank you @kevinhankens ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From #1674
According to the REST API docs:
Currently on startup
createAuthScheme()only allows for one header when validating theidentitySourceentry.Motivation and Context
This is preventing us from running serverless offline with our production configuration of using multiple headers to cache auth.
How Has This Been Tested?
Tested locally and added integration tests.
Screenshots (if appropriate):