fix(layers): retrieve layer using ARN #1684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aws-sdk method `GetLayerVersionCommand` was not passing the `VersionNumber` input parameter, therefore, downloading layers was not working properly. With this change the `layerArn` parameter is parsed to identify whether it points to the `latest` version of the layer or specific version and downloads it using the API method `GetLayerVersionByArnCommand` which does not require a separate input parameter to specify the layer version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change the
layerArnparameter is parsed to identify whether it points to thelatestversion of the layer or specific version and downloads it using the API methodGetLayerVersionByArnCommandwhich does not require a separate input parameter to specify the layer versionMotivation and Context
The aws-sdk method
GetLayerVersionCommandwas not passing theVersionNumberinput parameter, therefore, downloading layers was not working properly.Some people were reporting issues with the download of layers like in #1263
How Has This Been Tested?
The feature has been tested using the following repository: serverless poc