feat: support Go on provided.al2 runtime #1691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the current runtime used for Go on AWS. The `go1.x` runtime is EOL as its underlying AMI became EOL on 2020-12-31 and `provided.al2` is its replacement (https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-to-al2/). Whilst the AMI is still under extended maintenance support, this extends only until 2023-12-31 (https://aws.amazon.com/blogs/aws/update-on-amazon-linux-ami-end-of-life/). This also ensures that any `vendor/` directories from Go in the runtime tests are ignored.
|
We need this functionality to run offline using go in the provided.al2 runtime |
|
Why hasn't this been merged? |
kevingilbert100
approved these changes
Dec 20, 2023
|
Just an FYI on this: |
|
any news ????? |
|
As the go1.x runtime is now officially deprecated and will not get any security updates the new runtimes |
|
gotta be accepted @dherault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for the current Go runtime,
provided.al2, used on AWS Lambda.Motivation and Context
The
go1.xruntime is EOL as its underlying AMI became EOL on 2020-12-31 andprovided.al2is its replacement (https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-to-al2/). Whilst the AMI is still under technically under extended maintenance support, this extends only until 2023-12-31 (https://aws.amazon.com/blogs/aws/update-on-amazon-linux-ami-end-of-life/).The method here for checking the runtime and the handler's suffix (e.g. its file extension) may appear somewhat brittle but the GoRunner's internals implicitly require the
.gosource to be available and thus the handler already needs to besome/path/function.go.How Has This Been Tested?
Added integration tests with
provided.al2runtime and Go handler. Also tested locally in my current project.Screenshots (if appropriate):