Support Empty Identity Source for Request Lambda Authorisers #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for empty identity sources on request authorisers.
Motivation and Context
If you have a custom authoriser that supports checking multiple identity sources, you need to override the default identity source provided by AWS such that AWS does not validate any identity sources before calling the lambda authoriser. This is because AWS validates that all identity sources are present before calling the lambda authoriser, and since one of more of the identity sources may not be present this becomes an issue.
This used to work in version
11.3.0but has been broken since.How Has This Been Tested?
This has been tested locally to ensure that when a identity source of
''has been specified the custom authoriser is still run and is able to deny or approve the request.Screenshots (if appropriate):