Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responses without default key #1751

Merged

Conversation

DorianMazur
Copy link
Collaborator

Description

This pull request introduces fixes for two issues in the serverless-offline repository:
Issue #1705 & Issue #1680 : Resolved a TypeError encountered when destructuring properties from an undefined 'chosenResponse' object in HttpServer.js.

Motivation and Context

Fixing Issue #1705 & #1680 enhances the response handling mechanism and also resolves a critical bug that hinders the normal functionality.

How Has This Been Tested?

Tests were conducted by replicating the scenarios described in the issues. Additional e2e tests were added to cover the new scenarios and ensure no regressions in other parts of the code.

@DorianMazur DorianMazur changed the title fix: responses without default key fix: responses without default key #1705 #1680 Jan 10, 2024
@DorianMazur DorianMazur changed the title fix: responses without default key #1705 #1680 fix: responses without default key Jan 10, 2024
@DorianMazur
Copy link
Collaborator Author

@dnalborczyk Do you have some time to check this? It would simplify my codebase, because now I need to add everywhere default response. Also I attached 2 issues that are related to this PR.

@dnalborczyk
Copy link
Collaborator

@dnalborczyk Do you have some time to check this? It would simplify my codebase, because now I need to add everywhere default response. Also I attached 2 issues that are related to this PR.

thank you for the PR @DorianMazur ! I'll have a look in the next coming days. hang tight.

@DorianMazur
Copy link
Collaborator Author

@dnalborczyk Any news?

@vadymhimself
Copy link

+1 @dnalborczyk

1 similar comment
@JoshuaCEnrico
Copy link

+1 @dnalborczyk

@DorianMazur
Copy link
Collaborator Author

@dherault @dnalborczyk I noticed that this package has pull requests that have been pending for long time, including this one which has been waiting for 4 months. If you are seeking for additional maintainers to help manage the project, I would be happy to assist.

@dherault
Copy link
Owner

That's great!
We are indeed looking for maintainers.
Please send me an email. You'll find it on my personal website on my GitHub profile.

@DorianMazur DorianMazur merged commit 9ce688a into dherault:master Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants