fix: Support ALB Event response headers #1756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. This would help us with a solution based on ALB where we need to return redirect and cookies for our web app. Our work around for this is just to deploy the functions and test there, which is really sluggish for us! |
|
thank you for the PR @corwinm ! could you run I'll have a look over your PR in the next coming days. |
corwinm
force-pushed
the
alb-response-headers
branch
from
7859424
to
dae8a8e
Compare
|
Sorry @dnalborczyk, I meant to comment back. I ran prettier and updated the PR. Turns out I needed to configure my prettier plugin to run on yaml (or just use the script before committing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR adds support for ALB Event handlers to return headers.
This enables different "Content-Type" or "Set-Cookie" headers.
Fixes #1728
How Has This Been Tested?
Examples were added to manually test as well as integration tests added.
Screenshots (if appropriate):