Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response parameters bug fix #757

Merged
merged 2 commits into from Jul 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Expand Up @@ -585,6 +585,6 @@ We try to follow [Airbnb's JavaScript Style Guide](https://github.com/airbnb/jav
| :------------------------------------------------------------------------------------------------------------------------------: | :----------------------------------------------------------------------------------------------------------------------------------------: | :-----------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------------------------------------------------------------------------------: | :----------------------------------------------------------------------------------------------------------------------------: |
| [lteacher](https://github.com/lteacher) | [martinmicunda](https://github.com/martinmicunda) | [nori3tsu](https://github.com/nori3tsu) | [ppasmanik](https://github.com/ppasmanik) | [ryanzyy](https://github.com/ryanzyy) |

| [<img alt="constb" src="https://avatars3.githubusercontent.com/u/1006766?v=4&s=117" width="117">](https://github.com/constb) |
| :--------------------------------------------------------------------------------------------------------------------------: |
| [constb](https://github.com/constb) |
| [<img alt="constb" src="https://avatars3.githubusercontent.com/u/1006766?v=4&s=117" width="117">](https://github.com/constb) | [<img alt="jormaechea" src="https://avatars3.githubusercontent.com/u/5612500?v=4&s=117" width="117">](https://github.com/jormaechea) |
| :--------------------------------------------------------------------------------------------------------------------------: | :----------------------------------------------------------------------------------------------------------------------------------: |
| [constb](https://github.com/constb) | [jormaechea](https://github.com/jormaechea) |
1 change: 1 addition & 0 deletions package.json
Expand Up @@ -89,6 +89,7 @@
"Jaryd Carolin (https://github.com/horyd)",
"Jeff Hall (https://github.com/electrikdevelopment)",
"jgilbert01 (https://github.com/jgilbert01)",
"Joaquin Ormaechea (https://github.com/jormaechea)",
"John McKim (https://github.com/johncmckim)",
"Jonas De Kegel (https://github.com/jlsjonas)",
"Joost Farla (https://github.com/joostfarla)",
Expand Down
2 changes: 1 addition & 1 deletion src/ApiGateway.js
Expand Up @@ -636,7 +636,7 @@ module.exports = class ApiGateway {
);

// responseParameters use the following shape: "key": "value"
Object.entries(responseParametersKeys).forEach(
Object.entries(responseParameters).forEach(
([key, value]) => {
const keyArray = key.split('.'); // eg: "method.response.header.location"
const valueArray = value.split('.'); // eg: "integration.response.body.redirect.url"
Expand Down