Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: declarative i18n [LIBS-154] #534

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Mar 12, 2021

WORK IN PROGRESS

Proposed implementation of LIBS-154

This change will:

  • support building i18n locales as separate exports of platform-built library (i.e. @dhis2/ui-widgets/d2-i18n/fr.locale.json) with appropriate exports declaration in package.json
  • implement logic for collecting locale strings from dependencies
  • generate i18n js modules into shell, rather than into app source
  • Add initialization and loading logic to app-adapter, including bundle-split locale modules and dynamically loaded (import()) strings per language (rather than including all strings in the main app bundle), including also the moment locale for a given locale
  • Use package validation and a codemod to remove generated sources from /src in apps and libs, update all ./locales/index.js and @dhis2/d2-i18n imports in the codebase, and correct package.json, .gitignore, and other config files as much as possible

@amcgee amcgee changed the title feat: declarative i18n feat: declarative i18n [LIBS-154] Mar 12, 2021
@stale
Copy link

stale bot commented Sep 19, 2021

Hi!

Due to a lack of activity on this issue over time (180 days) it seems to be stale. If still relevant, please provide information that moves it forward, e.g. additional information, a pull request with suggested changes, or a reason to keep it open.

Any activity will keep it open, otherwise it will be closed automatically in 30 days. Thanks! 🤖

1 similar comment
@stale
Copy link

stale bot commented Apr 17, 2022

Hi!

Due to a lack of activity on this issue over time (180 days) it seems to be stale. If still relevant, please provide information that moves it forward, e.g. additional information, a pull request with suggested changes, or a reason to keep it open.

Any activity will keep it open, otherwise it will be closed automatically in 30 days. Thanks! 🤖

@stale stale bot added the stale label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant