Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle session expiration [LIBS-169] #754

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Oct 4, 2022

Implement a user workflow in App Platform to handle session expiration and allow the user to re-authenticate

This is a work-in-progress, I've based it on #748 for now but will update target to master once that has been merged

Requires dhis2/app-runtime#1266
Requires dhis2/ui#1161

TODO

  • Styling improvements @cooper-joe
  • Modal height issue
  • Actually check for auth status (Required app-runtime change)
  • Make permanent AlertBar non-dismissable (Requires ui change)
  • Better error handling
  • Test with different login configurations
  • Consider opening login page with _blank target instead of modal
  • Consider implementing proper login API
  • Check functionality under different network conditions
  • Use experimental d2.config flag
  • Support logout?

From Struts-based login.vm

  • OIDC provider login
  • Use messages from system config
  • Password recovery?

Screen Recording 2022-10-05 at 01 23 41

Base automatically changed from feat-headerbar-update-notification to master October 6, 2022 16:42
@amcgee amcgee changed the title feat: handle session expiration feat: handle session expiration [LIBS-169] Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant