chore: allow for unversioned api links #1374
Draft
+64
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomzemp
commented
Feb 20, 2024
| @@ -22,3 +22,7 @@ export interface Config { | |||
| serverVersion?: Version | |||
| systemInfo?: SystemInfo | |||
| } | |||
|
|
|||
| export interface ConfigWithSkipApiVersion extends Config { | |||
There was a problem hiding this comment.
The extra props provided to provider are actually already being passed downwards (https://github.com/dhis2/app-runtime/blob/master/services/data/src/react/components/DataProvider.tsx#L36-L39)
but the type definition used (e.g. https://github.com/dhis2/app-runtime/pull/1374/files#diff-accda02931529da3af34ae8dbe9c0ea5549c444fdbcaf5a7d504a086dfd9331eR76) caused problems, so I'm extending it.
I'm not sure what the logic was of originally passing the props as part of the config, so I haven't updated things any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-405
Key features
1.Note this PR is a modification to app-runtime required by login_app. The main implementation of the ticket is in app-platform: dhis2/app-platform#831
The public endpoints (e.g. api/loginConfig) do not support including version (so api/41/loginConfig is not public). Hence, this PR updates to get a
skipApiVersionpassed to the Provider by app-adapter to indicate that the app should not use versions in its requests.Checklist