This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
chore: package upgrades vue3 #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview ready! |
|
✔️ Deploy Preview ready! |
|
test utils 2.0 released today. updated in this branch, all tests passing, everything looks good. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue 3 version of upgrading packages.
Note we cannot actually merge this until the next release of vue-test-utils now that my PR vuejs/test-utils#1462 to fix the bug has been merged.
Seems that due to a jsdom update we now have to trigger both a click AND change event on clickable inputs (checkboxes/radios and such) to get it working as it was before.
removed --require jsdom-global/register from tests as vue-cli appears to configure and use jsdom on it's own.
Moved combobox a11y attrs to the input itself as we did in the vue2 PR as well
Removed test configuration files as they haven't been used at all since we switched over to vue-cli a long time ago.