-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CI workflow error & add separate reference files for different platforms #2633
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@wojtekmaj looks good but tests are failing |
I can actually reproduce that locally. jay-peg seemed to have originally been released with the wrong configuration in package.json. You've fixed that in diegomura/jay-peg@d88f86c but in our lockfile, there's still an old unpatched version 1.0.0, causing the issue. Patched it up locally and forgot about it 馃檲 You can bump the dependency and the tests will be green. |
Dependency bumped in #2635. |
Turns out, generated PDFs differ slightly from platform to platform. As the previous reference file I generated comes from macOS, it fails when E2E is ran on linux. This fixes that by introducing platform-specific reference files. Note: without diegomura#2633, E2E will error, and without diegomura#2635, CJS E2E will still fail.
Turns out, generated PDFs differ slightly from platform to platform. As the previous reference file I generated comes from macOS, it fails when E2E is ran on linux. This fixes that by introducing platform-specific reference files. Note: without diegomura#2633, E2E will error, and without diegomura#2635, CJS E2E will still fail.
Turns out, generated PDFs differ slightly from platform to platform. As the previous reference file I generated comes from macOS, it fails when E2E is ran on linux. This fixes that by introducing platform-specific reference files.
That's more like it |
@diegomura Sorry for pinging you, but can we prioritize this PR? Having all the other PRs without CI running is affecting us quite badly 馃檲 |
Follow up after #2631 馃珷
Fixes invalid syntax in workflow file.
Also, it turns out, generated PDFs differ slightly from platform to platform. As the previous reference file I generated comes from macOS, it fails when E2E is ran on linux. This fixes that by introducing platform-specific reference files.