-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: font selection regression #2747
base: master
Are you sure you want to change the base?
fix: font selection regression #2747
Conversation
|
@diegomura could you please merge this? |
@diegomura Plase merge this ! i need :( |
Yes I am using this library as well and right now the fonts are not working correctly. This fix is what I am waiting for! Please merge! |
@websnacks Dear, when can we see the change reflected in the library? I am waiting for this change to upload a code to improve a PDF |
When are the changes going to go up? I need it @diegomura @bdkopen |
I applied these changes, but still couldn't get the bold font back. Instead, to resolve it, I forced the resolution of "@react-pdf/layout" to point to
to your |
@Hatko @websnacks @diegomura I have not implemented @react-pdf/layout in my project This is where I have the problem |
@TomasSalas the fix needs to be applied to the |
@lecstor Could you help me with my project? since I work with NPM and I do not fully understand what you are telling me to be able to use what I need in the texts ?? |
@TomasSalas it looks like you could use this then.. https://www.npmjs.com/package/patch-package You'll need to open Then follow the instructions in |
@TomasSalas have a look at the PR. Did you remove lines 204 to 206? |
I believe If you are using yarn, replace
|
@lecstor yes remove lines 204 to 206 |
@TomasSalas not according to that screenshot in your last comment. These lines should not remain..
|
@lecstor |
@TomasSalas as long as you add the |
This recent change #2640 appears to have caused a regression where the first font used in a line of text is utilized for the entire line. This includes usage of
fontFamily
,fontWeight
, andfontStyle
.Changes
pickFontFromFontStack
to select fromfontStack
beforelastFont
. This should now properly prioritize fontspackages/layout/tests/text/fontSubstitution.test.js
Related
Example
Before
After