Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP moving mysql types.rs file to shared area #1905

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP moving mysql types.rs file to shared area #1905

wants to merge 1 commit into from

Conversation

virome
Copy link
Contributor

@virome virome commented Nov 6, 2018 •
edited

virome
virome commented Nov 6, 2018
View reviewed changes
diesel/src/mysql_like/backend.rs
type BindCollector = MysqlBindCollector;
type RawValue = [u8];
type ByteOrder = NativeEndian;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust is so cool. I'm surprised this self referential trait relationship even compiled

@weiznich weiznich requested a review from a team November 7, 2018 09:17
@virome virome force-pushed the split-mysql-and-mariadb-into-distinct-backends branch from f9a10fb to af914eb Compare March 16, 2019 19:59
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Apr 15, 2021

@weiznich
Is this PR still worth working on? If so, I'm going to take over this.

@virome
Copy link
Contributor Author

virome commented Apr 15, 2021

@weiznich
Is this PR still worth working on? If so, I'm going to take over this.

I'm not currently working on this, no. You can take over if you'd like. I ran into some hangups trying to make diesel/src/mysql/types/mod.rs be generic over both backends to avoid duplication, but someone with a bit more rust experience might know the correct approach.

@weiznich
Copy link
Member

@TaKO8Ki In principle this is something worth working on, but this is a quite large change and therefore quite a lot of work. Ideally the implementation of a mariadb backend would be done by someone that is interested in maintaining that backend.

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Apr 18, 2021

@weiznich Ok. I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@virome @TaKO8Ki @weiznich