Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Help -> Open User Data Folder menu button #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okdistribute
Copy link
Contributor

@okdistribute okdistribute commented Oct 12, 2020

Is this menu button useful to folks?

Should it be under File, View, or Help?

Screenshot from 2020-10-12 15-34-47
Screenshot from 2020-10-12 15-35-04

@gmaclennan
Copy link
Member

Yes, this could be very useful, particularly on Windows where opening this folder is tricky to explain.

However, this is also a risk, since accidentally moving files in this folder can break things. We do not want the "average user" clicking around and exploring and changing things without ensuring that they first understand what the consequences might be.

I think we should aim for users never needing to touch this folder. However, short-term it seems like users do need to access this folder for debugging, so short-term it is useful to have a way for users to access it.

One small tweak might be to add both this and the "Beta channel" option to a sub-menu called "Advanced…" under the Help menu. I think the "Help" is the most obvious location for this menu option, because the user should only be accessing this as part of a trouble-shooting workflow.

@aliya-ryan
Copy link
Member

Thanks Karissa - I agree with Gregor that this is very useful, also on a mac it is hard to explain how to find this hidden folder, but similarly I would want to be very cautious about risks of people accessing it and doing things in it without knowing that that is where all the data is stored and can be lost or broken from.

I wonder if before opening the folder it could first go to a popup box that gave a warning to people so they would have to click an additional 'OK' to understanding risks of going into that folder - or some other UX feature to safeguard against data loss or corruption.

I would be hesitant to say to implement it right away without any further precaution or information to the user.

@gmaclennan
Copy link
Member

Ok, let's hold off merging this until:

  1. We move it under Help --> Advanced…
  2. We add a warning dialog that appears when the user selects this menu item and explains what this folder is and the dangers of moving / deleting files / folders in it, with two actions: (A) Continue to open folder; (B) Cancel / go back.

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested in #444 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants