Es/chore settings about and config #717
Conversation
| window.location.reload() | ||
| // userConfig.importSettings(result.filePaths[0], err => { | ||
| // if (err) return onerror(err) | ||
| // ipc.send('reload-config', async err => { |
There was a problem hiding this comment.
I need to call this IPC call. this IPC call originally was being sent from the main process to mapeo-core, which is a background process.
Now we are sending this from a renderer process. Do you know the best way to do this? @gmaclennan
Should i send an IPC call to the main thread, and then that IPC sends and ipc call to mapeo-core?
There was a problem hiding this comment.
@ErikSin we set up a MessageChannel to communicate between renderer processes. There is currently a message channel established between the mapeo-core background process and the frontend. The message handlers are exported from mapeo-core/index.js, and the coordination between the message channel and the handlers is in src/background/index.js. The initial connection of the MessageChannels needs to be coordinated via the main process, which is done here: https://github.com/digidem/mapeo-desktop/blob/master/src/background/index.js. Finally on the front-end renderer process the channel is connected in https://github.com/digidem/mapeo-desktop/blob/master/src/renderer/index-preload.js.
If you want to do IPC with mapeo-core, it is a question of adding extra handler methods to mapeo-core/index.js and calling them from within https://github.com/digidem/mapeo-desktop/blob/master/src/renderer/new-api.js, which has access to the message channel.
If you want to do IPC to a different background renderer process (e.g. not mapeo-core), then you will need to set up a new channel, and attach it to window in the renderer. I can help with more details if that is what you need.
Added Settings menu, and ability to change config.