Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: initialize with storage path instead of database #119

Merged
merged 3 commits into from Feb 12, 2024

Conversation

EvanHahn
Copy link
Contributor

The core of this change:

 const mapServer = createMapServer(
   {},
-  { database: new Database('./example.db') }
+  { storagePath: './map-server-example.db' }
 )

See also: #92, #93, this comment.

The core of this change:

```diff
 const mapServer = createMapServer(
   {},
-  { database: new Database('./example.db') }
+  { storagePath: './map-server-example.db' }
 )
```

See also: [#92], [#93], [this comment][comment].

[#92]: #92
[#93]: #93
[comment]: #100 (comment)
@EvanHahn EvanHahn mentioned this pull request Feb 11, 2024
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a needed change in the package.json, changes lgtm!

package.json Show resolved Hide resolved
@EvanHahn EvanHahn merged commit 0b2467f into master Feb 12, 2024
3 checks passed
@EvanHahn EvanHahn deleted the manage-own-database branch February 12, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants