Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade and modularize app #75

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Upgrade and modularize app #75

wants to merge 31 commits into from

Conversation

GeorgSchneider
Copy link
Contributor

@GeorgSchneider GeorgSchneider commented Jan 4, 2023 •
edited

This PR incorporates several major changes:

  • Daml Finance dependencies have been updated to latest 1.0.0 (resp. 0.2.0 for alpha) packages
  • App is split into interface and implementation packages per service
  • UI only depends on interface packages (of Daml Finance and the app itself)
  • Aligns build infra (CI scripts) with Daml Finance

Implements #73

@GeorgSchneider
Add base service interface
ada89d2
@GeorgSchneider
Add custody service interfaces
f77cc7d
@GeorgSchneider
Implement custody service interfaces
8ccd9d2
@GeorgSchneider
Add interfaces for custody auto service
25f95bb
@GeorgSchneider
Use custody services interfaces in UI
5db5674
@GeorgSchneider
Add issuance interfaces
ffa3e8c
@GeorgSchneider
Add interfaces for listing
fb1d365
@GeorgSchneider
Add auction and bidding service interfaces
c5d8d90
@GeorgSchneider
Add interfaces for more services
8600614
@GeorgSchneider
Instrument.K -> InstrumentKey
ef3835b
@GeorgSchneider
Add interfaces for settlement and structuring services
5dad8f3
@GeorgSchneider
Add interfaces for trading service
7d2adb4
@GeorgSchneider
SDK update
4c84a6d
@GeorgSchneider
Add interfaces for dex service
374058f
@GeorgSchneider
Update UI for new service interfaces
363d185
@GeorgSchneider
Model side of Daml Finance 1.0 upgrade
b306fa1
@GeorgSchneider
Fix up several rule placements
736c53a
@GeorgSchneider
Fix service and rule placement, and trading and auction auth
0573d7b
@GeorgSchneider
Build separate packages
abb8acf
@GeorgSchneider
Remove log files
cc36dad
@GeorgSchneider
Fix up UI side for multi-package support
3760cc4
@GeorgSchneider GeorgSchneider requested a review from a team as a code owner January 4, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-weir brian-weir brian-weir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeorgSchneider @brian-weir