Skip to content

Commit

Permalink
[2.8] remove check-proto workaround for 2.8.3 (#19049)
Browse files Browse the repository at this point in the history
The workaround was in place for the transition period, as 2.8.3 was not
in a subfolder.
  • Loading branch information
garyverhaegen-da committed Apr 19, 2024
1 parent 4604fa2 commit 6ee1173
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions sdk/ci/check-protobuf-stability.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,9 @@ function check_non_lf_protos() {
git fetch origin
fi

if [ "$commitish" = "v2.8.3" ]; then # TODO remove when 2.8.4 gets published
against_prefix=.
else
against_prefix=sdk
fi


against_config=$(mktemp -d)
for buf_module in "${BUF_MODULES_AGAINST_STABLE[@]}"; do
git show $commitish:$against_prefix/$buf_module > $against_config/$buf_module
git show $commitish:sdk/$buf_module > $against_config/$buf_module
buf breaking --config "sdk/${buf_module}" --against "./.git#$commitish_type=$commitish" --against-config "$against_config/$buf_module"
done

Expand Down

0 comments on commit 6ee1173

Please sign in to comment.