Skip to content

Commit

Permalink
Keep using NodeJS 14 for the compatibility tests
Browse files Browse the repository at this point in the history
NodeJS 16 is needed for M1 compatibility, but it breaks the
compatibility tests. So, for now, we stick to the older version for the
compatibility tests.
  • Loading branch information
aherrmann committed Apr 7, 2022
1 parent 9161060 commit afcce40
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion compatibility/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ nixpkgs_package(

nixpkgs_package(
name = "node_nix",
attribute_path = "nodejsNested",
attribute_path = "nodejs14Nested",
build_file_content = 'exports_files(glob(["node_nix/**"]))',
fail_not_supported = False,
nix_file = "@daml//nix:bazel.nix",
Expand Down
1 change: 1 addition & 0 deletions nix/bazel.nix
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ let shared = rec {
# rules_nodejs expects nodejs in a subdirectory of a repository rule.
# We use a linkFarm to fulfill this requirement.
nodejsNested = pkgs.linkFarm "nodejs" [ { name = "node_nix"; path = pkgs.nodejs; }];
nodejs14Nested = pkgs.linkFarm "nodejs" [ { name = "node_nix"; path = pkgs.nodejs14; }];

sass = pkgs.sass;

Expand Down
1 change: 1 addition & 0 deletions nix/nixpkgs.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ let
# package overrides
overrides = _: pkgs: rec {
nodejs = pkgs.nodejs-16_x;
nodejs14 = pkgs.nodejs-14_x;
ephemeralpg = pkgs.ephemeralpg.overrideAttrs(oldAttrs: {
installPhase = ''
mkdir -p $out
Expand Down

0 comments on commit afcce40

Please sign in to comment.