Skip to content

Commit

Permalink
Disable create-daml-app tests on MacOS M1
Browse files Browse the repository at this point in the history
These fail to build because puppeteer fails to install Chromium on M1.
See #13250.
  • Loading branch information
aherrmann committed Mar 17, 2022
1 parent a4ed305 commit ba58475
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions daml-assistant/integration-tests/BUILD.bazel
@@ -1,7 +1,7 @@
# Copyright (c) 2022 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
load("//bazel_tools:haskell.bzl", "da_haskell_library", "da_haskell_test")
load("@os_info//:os_info.bzl", "is_windows")
load("@os_info//:os_info.bzl", "is_darwin_arm64", "is_windows")
load("@build_environment//:configuration.bzl", "mvn_version")

genrule(
Expand Down Expand Up @@ -199,7 +199,9 @@ genrule(
"@nodejs//:node_bin",
"@nodejs//:npm_bin",
],
) if not is_windows else None
# Broken on M1 due to puppeteer failing to install Chromium.
# See https://github.com/digital-asset/daml/pull/13250.
) if not (is_darwin_arm64 or is_windows) else None

da_haskell_library(
name = "create-daml-app-tests-lib",
Expand Down Expand Up @@ -234,7 +236,7 @@ da_haskell_library(
"//libs-haskell/da-hs-base",
"//libs-haskell/test-utils",
],
) if not is_windows else None
) if not (is_darwin_arm64 or is_windows) else None

da_haskell_test(
name = "create-daml-app-tests-proj-name",
Expand All @@ -255,7 +257,8 @@ da_haskell_test(
flaky = True, # npm/jest/puppeteer can be flaky
hackage_deps = ["base"],
main_function = "DA.Daml.Assistant.CreateDamlAppTestsMain.main",
# Exclusive until we stop hardcoding port numbers in index.test.ts
tags = ["exclusive"],
tags =
# Exclusive until we stop hardcoding port numbers in index.test.ts
["exclusive"],
deps = [":create-daml-app-tests-lib"],
) if not is_windows else None
) if not (is_darwin_arm64 or is_windows) else None

0 comments on commit ba58475

Please sign in to comment.