Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger-on-memory: Lock on read. #12715

Merged
2 commits merged into from Feb 2, 2022
Merged

ledger-on-memory: Lock on read. #12715

2 commits merged into from Feb 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2022

I hoped we could get away with not doing this, but no such luck. Scala 2.13.8 (scala/scala#9258) makes the problem visible, but it was always there.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

I hoped we could get away with not doing this, but no such luck.
Scala 2.13.8 makes the problem visible, but it was always there.

CHANGELOG_BEGIN
CHANGELOG_END
@ghost ghost self-requested a review as a code owner February 2, 2022 14:58
@ghost ghost merged commit 34287f6 into main Feb 2, 2022
@ghost ghost deleted the samir/ledger-on-memory/lock-on-read branch February 2, 2022 15:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants