JSON API Upgrades: ETX-500 require fully qualified template ids #19149
Conversation
raphael-speyer-da
force-pushed
the
rls/etx-500-require-fully-qualified-template-ids
branch
3 times, most recently
from
e112a7d
to
c4bd32e
Compare
raphael-speyer-da
force-pushed
the
rls/etx-500-require-fully-qualified-template-ids
branch
2 times, most recently
from
529b27c
to
69f7fb5
Compare
raphael-speyer-da
requested review from
S11001001,
erwin-ramirez-da and
simonmaxen-da
| @@ -66,6 +66,9 @@ object HttpServiceTestFixture extends LazyLogging with Assertions with Inside { | |||
|
|
|||
| private val doNotReloadPackages = FiniteDuration(100, DAYS) | |||
|
|
|||
| // This may need to be updated if the Account.daml is updated. | |||
| val staticPkgIdAccount = "b3c9564bb7334bfd0f82099893eba518afc3b68a4d5c66cb2835498252db93e9" | |||
There was a problem hiding this comment.
This code does not currently depend on the integration-tests-lib, which reads current package ids of each package. The package ids are not expected to be updated often, but we help ensure this value is kept up-to-date with this assertion
https://github.com/digital-asset/daml/pull/19149/files?diff=split&w=1#diff-f3396356d430497a19c0ec5e05f9a95cb546414b908043c6037c70eb1d869eb3R76
| ) | ||
| finalResult <- { | ||
| val packageId = (x: C.RequiredPkg).packageId | ||
| if (packageId.startsWith("#")) { // Used package name, not package id |
There was a problem hiding this comment.
The presence of a package name now has the same resolution logic that the absence of a package id had previously. The package ids that share this name may be updated on the ledger in the background, so we may need to dial back into the ledger to find out about the current set of package ids.
sdk/ledger-service/http-json/src/main/scala/com/digitalasset/http/ContractsService.scala
Outdated
Show resolved
Hide resolved
raphael-speyer-da
force-pushed
the
rls/etx-500-require-fully-qualified-template-ids
branch
from
69f7fb5
to
4162716
Compare
raphael-speyer-da
deleted the
rls/etx-500-require-fully-qualified-template-ids
branch
We still need to distinguish package name vs package id at the point where we resolve contract type ids, so we keep the logic that we used on missing package id, and do the same thing in the case of a package name. This logic deals with the fact that new packages can get uploaded in the background, and so we need to be able to treat a package name as a dynamically late-bound mapping to specific package.