Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest jsonld, http-client, webcrypto. #553

Merged
merged 9 commits into from Feb 20, 2024

Conversation

dmitrizagidulin
Copy link
Member

@dmitrizagidulin dmitrizagidulin commented Feb 8, 2024

Note that this is a PR to Vojtech's feat/add-expo RN upgrade branch.

@dmitrizagidulin dmitrizagidulin mentioned this pull request Feb 8, 2024
@dmitrizagidulin
Copy link
Member Author

@vonovak As part of testing the RN upgrade PR, I added a unit test to verify a VC. But running it in jest gives a segmentation fault. Can you take a look and see if there's something I'm missing?

To reproduce, run install, then run test:

$ npm t
> learner-credential-wallet@1.0.0 test
> jest

RUNS  test/verify.test.ts
Segmentation fault (core dumped)

@dmitrizagidulin
Copy link
Member Author

@vonovak Oh interesting, checking the lint CI job (which, btw, we need to separate into lint and test jobs), the error seems to be:

          error: Error: Could not load "StatusList2021Credential"; reason: NotFoundError loading "https://digitalcredentials.github.io/credential-status-playground/JWZM3H8WKU": A dynamic import callback was invoked without --experimental-vm-modules
              at _checkStatus (/home/runner/work/learner-credential-wallet/learner-credential-wallet/node_modules/@digitalcredentials/vc-status-list/dist/index.js:190:17)

Will investigate what this dynamic import is..

@dmitrizagidulin
Copy link
Member Author

dmitrizagidulin commented Feb 11, 2024

@vonovak ok, more info on the segfault. The dynamic import callback error is the result of the http-client library interacting with Jest. It was supposed to be partially addressed by PR digitalbazaar/http-client#35 and issue digitalbazaar/http-client#34 (see discussion / notes there).
I'm not entirely sure what to do here, since running NODE_OPTIONS=--experimental-vm-modules npx jest still causes the segfault. (See also the discussion at jestjs/jest#9430 )

@dmitrizagidulin dmitrizagidulin marked this pull request as ready for review February 16, 2024 19:27
@dmitrizagidulin
Copy link
Member Author

Thanks again to @vonovak; merging this PR into the feat/add-expo branch / PR #550

@dmitrizagidulin dmitrizagidulin merged commit b925b0f into feat/add-expo Feb 20, 2024
3 checks passed
@dmitrizagidulin dmitrizagidulin deleted the update-jsonld branch February 20, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants