Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove % from sessionSecret #1963

Merged
merged 1 commit into from
May 15, 2024

Conversation

amitaibu
Copy link
Collaborator

@amitaibu amitaibu commented May 14, 2024

This is the output I get when I execute on Ubuntu:

$ new-session-secret
vKfe21qHkQwwLAf+vWVEhywVMujoZlsg2ZBRuIKlrAfM4TlGgaaj5MOfplDdmpOlkqTkAttpy32GnLhPIwiF7+kB+e4ofoyOkqWNz9//pZts7jxkdgOc8MoY7FY3FH8F%   

Notice the % on the end. PR is an attempt to add a new line at the end of the string.

However, I don't know how to execute this locally to test it.

@mpscholten mpscholten marked this pull request as ready for review May 15, 2024 08:28
@mpscholten
Copy link
Member

Thanks! 👍 Looks good to me.

For testing you should be able to load this into ghci from within your IHP directory:

cd ihp
ghci
:l exe/IHP/CLI/NewSessionSecret.hs

@amitaibu
Copy link
Collaborator Author

I'm getting an error

image

@mpscholten
Copy link
Member

Did you start ghci from within the IHP folder? There the .ghci file should enable the BlockAguments extension via https://github.com/digitallyinduced/ihp/blob/master/.ghci#L32

@amitaibu
Copy link
Collaborator Author

I missed chmod go-w .ghci

Now it's working well.

ghci> main
IerLodatg74w7ktiw75uJiMkXbyN6XHhgD4tEUTIn3Ztg9L9QE8m372rWWHm7rSpz2sMNYpnDaH4UflIlDmh9u1/Xz0dAyyj3OhZx6kyYF3G08r5wKNpjSLLHludPL+N
ghci> 

@amitaibu amitaibu changed the title WIP: Remove % from sessionSecret Remove % from sessionSecret May 15, 2024
@mpscholten mpscholten merged commit d391ccb into master May 15, 2024
2 checks passed
@mpscholten mpscholten deleted the NewSessionSecret-remove-percentage-symbol branch May 15, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants