loadbalancers: support loadBalancerSourceRanges #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @J0sh0nat0r , this indeed looks like a nice addition. Could you possibly fix the conflicting files in this PR ? We also want this feature supported on our end. Would you be able to continue working on this PR ? I'm asking because the last changes are going back quite some time and we wouldn't want to duplicate the work if there is already a PR in progress. Thanks ! |
|
Closing this PR in favor of #731 (rebased and slightly adapted version of this PR) Thank you @J0sh0nat0r for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for
loadBalancerSourceRangesas a configuration source for the recently added firewall support.I understand this may be somewhat redundant given that it's actually less powerful than the annotations, however, given that it's standardised and easy to support I think it's nice-to-have.
I wasn't quite sure where to document this so I left a note under the existing annotations documentation, but if there's somewhere better suited (the examples README perhaps?) let me know