Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Date+Extension not public #23

Open
wants to merge 1 commit into
base: new
Choose a base branch
from
Open

Make Date+Extension not public #23

wants to merge 1 commit into from

Conversation

basvankuijck
Copy link

@basvankuijck basvankuijck commented Feb 7, 2018 •
edited

Because it conflicts with, for instance, SwiftDate.

@basvankuijck
Make Date+Extension not public
cfebc1f 
Because it conflicts with,  for instance,
[SwiftDate](https://github.com/malcommac/SwiftDate)
@basvankuijck
Copy link
Author

Mind me asking why you included some public extensions (like Date, Locale, NSAttributedString, etc.) and not using them in your own source? I understand those extensions are useful, but in the end could up conflicting with other libraries.

SigmundRakes
SigmundRakes approved these changes Apr 21, 2018
View reviewed changes
Copy link

@SigmundRakes SigmundRakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes the Library usable with Others such as SwiftDat - I don't see why this wouldn't be seen as great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pahnev pahnev pahnev approved these changes

@SigmundRakes SigmundRakes SigmundRakes approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvankuijck @pahnev @SigmundRakes