Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce require-selections on FragmentSpreads within GraphQLUnionTypes #2319

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maciesielka
Copy link

Description

Enforces require-selections on FragmentSpreads within GraphQLUnionTypes, like it already does for InlineFragments

Fixes #2318

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

(Technically this can cause new violations in existing codebases, but I'd consider this to be missing functionality and thus a bug more than a new feature).

How Has This Been Tested?

Added a unit test that describes and reproduces the issue well.

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 11ebcef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-eslint/eslint-plugin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maciesielka maciesielka force-pushed the maciesielka/require-selections-in-unions branch 2 times, most recently from b453dd8 to 5b86ef9 Compare May 15, 2024 15:54
@maciesielka maciesielka marked this pull request as ready for review May 15, 2024 15:59
@maciesielka maciesielka force-pushed the maciesielka/require-selections-in-unions branch 2 times, most recently from 5b86ef9 to 541e40a Compare May 15, 2024 19:35
@maciesielka maciesielka force-pushed the maciesielka/require-selections-in-unions branch from 541e40a to 11ebcef Compare May 15, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require-selections does not report issues on FragmentSpreads within GraphQLUnionType
1 participant