Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove prettier rule, add related docs #397

Merged
merged 2 commits into from May 18, 2021
Merged

feat: remove prettier rule, add related docs #397

merged 2 commits into from May 18, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Apr 22, 2021

馃毃 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #395

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • examples/prettier

Test Environment:

  • OS: macOS
  • @graphql-eslint/eslint-plugin: 0.9.1
  • NodeJS: 14.16

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2021

馃 Changeset detected

Latest commit: 7d9bb70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-eslint/eslint-plugin Minor
@graphql-eslint/example-prettier Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha
Copy link
Collaborator

This is great, thank you @JounQin !
Can you please just rebase your PR and then we can get this merged?

@dotansimha dotansimha self-requested a review May 18, 2021 09:26
@JounQin
Copy link
Contributor Author

JounQin commented May 18, 2021

@dotansimha Done!

@dimaMachina
Copy link
Owner

@JounQin i think you definitely must add *.ts/*.graphql to override object for turn off prettier/prettier rule

@JounQin
Copy link
Contributor Author

JounQin commented May 18, 2021

@B2o5T Oh, right, I'll add .jsx/.tsx too soon.

@dotansimha
Copy link
Collaborator

Thank you @JounQin . I'm merging this one, but might take a few days to release, since I want to bump a major in this one, and I plan to squeeze in a few more change for v1.

@dotansimha dotansimha merged commit 14211d6 into dimaMachina:master May 18, 2021
@JounQin JounQin deleted the feat/deprecate_rule_prettier branch August 21, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate rule prettier since eslint-plugin-prettier itself supports virtual filenames correctly now
3 participants