-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web Apps: switched combobox to select2 #28701
Commits on Oct 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ab38860 - Browse repository at this point
Copy the full SHA ab38860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 288c96f - Browse repository at this point
Copy the full SHA 288c96fView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaacd10 - Browse repository at this point
Copy the full SHA aaacd10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 439b922 - Browse repository at this point
Copy the full SHA 439b922View commit details
Commits on Oct 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 11575ac - Browse repository at this point
Copy the full SHA 11575acView commit details -
No longer necessary because select2 doesn't allow you to enter free text.
Configuration menu - View commit details
-
Copy full SHA for 6ea3bcb - Browse repository at this point
Copy the full SHA 6ea3bcbView commit details
Commits on Nov 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 561a4cb - Browse repository at this point
Copy the full SHA 561a4cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70f0448 - Browse repository at this point
Copy the full SHA 70f0448View commit details
Commits on Nov 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 85f8ded - Browse repository at this point
Copy the full SHA 85f8dedView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7783e3 - Browse repository at this point
Copy the full SHA d7783e3View commit details
Commits on Nov 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ac807f5 - Browse repository at this point
Copy the full SHA ac807f5View commit details -
Restored onPreProcess and validation code
Even though the UI no longer allows invalid answers since it doesn't support free text, it's still possible for another question to update a combobox with an invalid answer.
Configuration menu - View commit details
-
Copy full SHA for 36ac455 - Browse repository at this point
Copy the full SHA 36ac455View commit details -
Configuration menu - View commit details
-
Copy full SHA for 367dd0d - Browse repository at this point
Copy the full SHA 367dd0dView commit details -
Restored additional validation code
This validation is now available to both comboboxes and dropdowns.
Configuration menu - View commit details
-
Copy full SHA for 0c19009 - Browse repository at this point
Copy the full SHA 0c19009View commit details
Commits on Nov 10, 2020
-
Restored valueAllowUnset binding
Without this, web apps initially sets the value of an empty combobox to null, but then the knockoout value binding sets it to undefined, which counts as a change and triggers answer validation.
Configuration menu - View commit details
-
Copy full SHA for 6c72078 - Browse repository at this point
Copy the full SHA 6c72078View commit details
Commits on Nov 11, 2020
-
Updated ComboboxEntry to use index for both answer and rawAnswer
This undoes 36ac455 and 0c19009, again removing the validation code because dropdowns don't allow invalid selections. What those commits missed is that the combobox needed to be updated to use the index for rawAnswer. Previously, the combobox was backed by a plain text input, which meant rawAnswer was text and the entry would look up that text's index. Now that there's a dropdown, both the validation and the lookups are no longer necessary. The only logic dealing with text is receiveMessage.
Configuration menu - View commit details
-
Copy full SHA for 3fb2a76 - Browse repository at this point
Copy the full SHA 3fb2a76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1482c36 - Browse repository at this point
Copy the full SHA 1482c36View commit details -
Updated dropdown and combobox to clear answer when options change
Previously, if options changed, the minimal dropdown would select whatever option was at the same index as the previous answer, and the combobox would should an 'invalid choice' error.
Configuration menu - View commit details
-
Copy full SHA for c39f408 - Browse repository at this point
Copy the full SHA c39f408View commit details
Commits on Nov 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 242a564 - Browse repository at this point
Copy the full SHA 242a564View commit details