Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Apps: switched combobox to select2 #28701

Merged
merged 19 commits into from
Nov 16, 2020
Merged

Commits on Oct 27, 2020

  1. Configuration menu
    Copy the full SHA
    ab38860 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    288c96f View commit details
    Browse the repository at this point in the history
  3. Added translations

    orangejenny committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    aaacd10 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    439b922 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Configuration menu
    Copy the full SHA
    11575ac View commit details
    Browse the repository at this point in the history
  2. Removed validation

    No longer necessary because select2 doesn't allow you to enter free text.
    orangejenny committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    6ea3bcb View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. Configuration menu
    Copy the full SHA
    561a4cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70f0448 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Configuration menu
    Copy the full SHA
    85f8ded View commit details
    Browse the repository at this point in the history
  2. Fixed lint error

    orangejenny committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    d7783e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. Added select2 to tests

    orangejenny committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    ac807f5 View commit details
    Browse the repository at this point in the history
  2. Restored onPreProcess and validation code

    Even though the UI no longer allows invalid answers since it doesn't support free text,
    it's still possible for another question to update a combobox with an invalid answer.
    orangejenny committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    36ac455 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    367dd0d View commit details
    Browse the repository at this point in the history
  4. Restored additional validation code

    This validation is now available to both comboboxes and dropdowns.
    orangejenny committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    0c19009 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Restored valueAllowUnset binding

    Without this, web apps initially sets the value of an empty combobox to null,
    but then the knockoout value binding sets it to undefined, which counts as a
    change and triggers answer validation.
    orangejenny committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    6c72078 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Updated ComboboxEntry to use index for both answer and rawAnswer

    This undoes 36ac455 and 0c19009, again removing the validation code
    because dropdowns don't allow invalid selections. What those commits
    missed is that the combobox needed to be updated to use the index for
    rawAnswer. Previously, the combobox was backed by a plain text input,
    which meant rawAnswer was text and the entry would look up that text's
    index. Now that there's a dropdown, both the validation and the lookups
    are no longer necessary. The only logic dealing with text is receiveMessage.
    orangejenny committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    3fb2a76 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1482c36 View commit details
    Browse the repository at this point in the history
  3. Updated dropdown and combobox to clear answer when options change

    Previously, if options changed, the minimal dropdown would select whatever
    option was at the same index as the previous answer, and the combobox
    would should an 'invalid choice' error.
    orangejenny committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    c39f408 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Configuration menu
    Copy the full SHA
    242a564 View commit details
    Browse the repository at this point in the history