Popup events #130
Popup events #130
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @dimfeld on Vercel. @dimfeld first needs to authorize it. |
🦋 Changeset detectedLatest commit: 7b069dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -0,0 +1,18 @@ | |||
| import { json } from '@sveltejs/kit'; | |||
There was a problem hiding this comment.
Could you make this a Vercel edge function as detailed at https://kit.svelte.dev/docs/adapter-vercel#deployment-configuration?
Since edge functions are billed for CPU time, not clock time, it will help prevent unexpected billing surprises if a lot of people unexpectedly start hitting this page.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New release going out tonight. Thanks! |
This adds
on:openandon:closeevents to the Popup class, and an example for how they might be used. I also took the opportunity to add Typescript annotations to the dispatched events for some of the other components in this project, as well.