Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic elements #7

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Add basic elements #7

wants to merge 36 commits into from

Conversation

dingo-d
Copy link
Owner

@dingo-d dingo-d commented Feb 14, 2024

Still a WIP

dingo-d and others added 30 commits November 19, 2022 12:51
@dingo-d
Add Element interface
a4ab395
@dingo-d
Add abstract element class
a627c92
@dingo-d
Initial implementation of the mj-text element
1f93550
@dingo-d
Update base test class
5728363
@dingo-d
Add tests for the mj-text element class
4ea8626
@dingo-d
Fix the phpcs issue in the abstract element class
312100f
@dingo-d
Add cleanup for test properties
7a3cdd6
@dingo-d
Reorder allowed attributes in alphabetical order
22a9ffe
@dingo-d
Remove gitkeep
d977088
@dingo-d
Add tests for the parser, renderer and some elements
691a20e 
Still a WIP and the tests will fail. Need to work on this when I find the time.
@dingo-d
Change parser to return a node instead of array of nodes
3a1207a
@dingo-d
Add renderer code
aff8b15
@dingo-d
Add conditional tag helper trait
b42bc18
@dingo-d
Add element factory
03fb6f9 
Factory should be used to quickly generate elements. Still a WIP, as I need to finish working on the text element, then start working on the others to see if this can be reused or not.
@dingo-d
Add abstract element class and the element class
1e21128 
See what parts we can abstract away for the prototype pattern.
@dingo-d
WIP text element
d8039d0
@dingo-d
Update dependencies
1084974
@dingo-d
Improve factory create method
6e4b960 
Exclude directories from the list.
@dingo-d
Add type validator helper
16bdc38 
Will be used to check passed attributes, and will probably need to have a lot more validators for css values. For instance alignment, etc.
@dingo-d
Allow creation of dynamic properties
4d0d579 
They are needed to create on the fly entities in the test.
@dingo-d
Add additional test for the render method
b65abf8 
They will currently fail, because I need to add column, section, body and mjml elements.
@dingo-d
WIP Modify the getHtmlAttributes and formatAttributes methods
a30ff7d 
Still need to write the code when the arguments are passed for the element.
@dingo-d
Add return type shape to the text element
4e4a9fb
@dingo-d
Add validators
c1058d5 
This could be a bit overengineered. I'm still not 100% sure 😅
@dingo-d
Add additional tests for the element formatting and overriding
6440e33
@dingo-d
Minor grammar fix in docblock
cd5804b
@dingo-d
Add types to allowed attributes for validation
dd5ea44
@dingo-d
Update abstract element class
07c4901 
Update global attributes, add validation checks for formatting attributes, still need to add render children method for the body and all elements that have child elements
@dingo-d
Remove renderContent method from the Element interface
3d92692
@dingo-d
Initial addition of body element
5dafac4 
Still WIP
@dingo-d
Extract the dependency on the validator out of the validation method
890c707
@dingo-d
Refactor validation code
2f1b31c 
No need to call upon the class, and pass it to the method, when we can just pass it as a dependency.
@dingo-d
Update the coverage composer command
ffce08a
@dingo-d
Update validators
67a1da3 
Update the text decoration one, update colors, fix lab and lch checks. Even though I think only rgb, rgba and hex and named colors are needed.
@dingo-d
Update tests for validators
d0c6e8a
@dingo-d
Fix phpcs issues
ff6813b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dingo-d