Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lucide support #45

Merged
merged 4 commits into from
Apr 28, 2024
Merged

Add Lucide support #45

merged 4 commits into from
Apr 28, 2024

Conversation

MrGVSV
Copy link
Contributor

@MrGVSV MrGVSV commented Apr 21, 2024

Resolves #38

This PR adds support for Lucide icons.

I wasn't sure what prefix to use so I went with Ld (as in LuciDe as well as Lucide.Dev), but this could just as easily be Li or something else. Open to ideas!

This also adds two methods to IconShape:

  • stroke_linecap (default: "butt")
  • stroke_linejoin (default: "miter")

Note

The first commit (651df61) contains the main changes. The second commit updates the other icon sets with the changes to IconShape.

@marc2332 marc2332 self-requested a review April 21, 2024 21:52
@marc2332 marc2332 added the enhancement New feature or request label Apr 21, 2024
@marc2332
Copy link
Member

wowow! Looks promising! I will test and review this asap! 🚀

@MrGVSV
Copy link
Contributor Author

MrGVSV commented Apr 22, 2024

Oops I think I need to update the README as well!

@marc2332
Copy link
Member

So cool! Nice job!

@marc2332 marc2332 merged commit 9faa544 into dioxus-community:main Apr 28, 2024
4 checks passed
@MrGVSV MrGVSV deleted the mrgvsv/lucide branch April 28, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lucide Support
2 participants