Fix bundle (re-)loading (#22013)

* Fix bundle (re-)loading (fixes #21942 and #21946)

* Add changeset

* Use .some instead of .find for checking existance

* Fix names

* Cleanup

* Add comments

* Update changeset

* moved out type check

* Clearer params, fix bundle check

* Use enabled state from parent

* Clarify changeset

---------

Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
Co-authored-by: Brainslug <tim@brainslug.nl>

.changeset/hot-dolphins-shop.md

@@ -0,0 +1,5 @@
+---
+'@directus/api': patch
+---
+
+Fixed bundle extension loading by updating extension settings when bundle entries have changed

api/src/extensions/lib/get-extensions-settings.ts

@@ -1,4 +1,4 @@
-import type { Extension, ExtensionSettings } from '@directus/extensions';
+import type { BundleExtension, Extension, ExtensionSettings } from '@directus/extensions';
 import { randomUUID } from 'node:crypto';
 import getDatabase from '../../database/index.js';
 import { ExtensionsService } from '../../services/extensions.js';
@@ -28,11 +28,44 @@ export const getExtensionsSettings = async ({
 	const existingSettings = await service.extensionsItemService.readByQuery({ limit: -1 });
 
 	const newSettings: ExtensionSettings[] = [];
+	const removedSettingIds: string[] = [];
 
 	const localSettings = existingSettings.filter(({ source }) => source === 'local');
 	const registrySettings = existingSettings.filter(({ source }) => source === 'registry');
 	const moduleSettings = existingSettings.filter(({ source }) => source === 'module');
 
+	const updateBundleEntriesSettings = (
+		bundle: BundleExtension,
+		bundleSettings: ExtensionSettings,
+		allSettings: ExtensionSettings[],
+	) => {
+		const bundleEntriesSettings = allSettings.filter(({ bundle }) => bundle === bundleSettings.id);
+
+		// Remove settings of removed bundle entries from the DB
+		for (const entry of bundleEntriesSettings) {
+			const entryInBundle = bundle.entries.some(({ name }) => name === entry.folder);
+
+			if (entryInBundle) continue;
+
+			removedSettingIds.push(entry.id);
+		}
+
+		// Add new bundle entries to the settings
+		for (const entry of bundle.entries) {
+			const settingsExist = bundleEntriesSettings.some(({ folder }) => folder === entry.name);
+
+			if (settingsExist) continue;
+
+			newSettings.push({
+				id: randomUUID(),
+				enabled: bundleSettings.enabled,
+				source: bundleSettings.source,
+				bundle: bundleSettings.id,
+				folder: entry.name,
+			});
+		}
+	};
+
 	const generateSettingsEntry = (folder: string, extension: Extension, source: 'local' | 'registry' | 'module') => {
 		if (extension.type === 'bundle') {
 			const bundleId = randomUUID();
@@ -66,8 +99,15 @@ export const getExtensionsSettings = async ({
 	};
 
 	for (const [folder, extension] of local.entries()) {
-		const settingsExist = localSettings.some((settings) => settings.folder === folder);
-		if (settingsExist) continue;
+		const existingSettings = localSettings.find((settings) => settings.folder === folder);
+
+		if (existingSettings) {
+			if (extension.type === 'bundle') {
+				updateBundleEntriesSettings(extension, existingSettings, localSettings);
+			}
+
+			continue;
+		}
 
 		const settingsForName = localSettings.find((settings) => settings.folder === extension.name);
 
@@ -85,24 +125,36 @@ export const getExtensionsSettings = async ({
 			continue;
 		}
 
-		if (!settingsExist) generateSettingsEntry(folder, extension, 'local');
+		generateSettingsEntry(folder, extension, 'local');
 	}
 
 	for (const [folder, extension] of module.entries()) {
-		const settingsExist = moduleSettings.some((settings) => settings.folder === folder);
-		if (!settingsExist) generateSettingsEntry(folder, extension, 'module');
+		const existingSettings = moduleSettings.find((settings) => settings.folder === folder);
+
+		if (!existingSettings) {
+			generateSettingsEntry(folder, extension, 'module');
+		} else if (extension.type === 'bundle') {
+			updateBundleEntriesSettings(extension, existingSettings, moduleSettings);
+		}
 	}
 
 	for (const [folder, extension] of registry.entries()) {
-		const settingsExist = registrySettings.some((settings) => settings.folder === folder);
-		if (!settingsExist) generateSettingsEntry(folder, extension, 'registry');
+		const existingSettings = registrySettings.find((settings) => settings.folder === folder);
+
+		if (!existingSettings) {
+			generateSettingsEntry(folder, extension, 'registry');
+		} else if (extension.type === 'bundle') {
+			updateBundleEntriesSettings(extension, existingSettings, registrySettings);
+		}
 	}
 
-	if (newSettings.length > 0) {
-		await database.insert(newSettings).into('directus_extensions');
+	if (removedSettingIds.length > 0) {
+		await service.extensionsItemService.deleteMany(removedSettingIds);
 	}
 
-	const settings = [...existingSettings, ...newSettings];
+	if (newSettings.length > 0) {
+		await service.extensionsItemService.createMany(newSettings);
+	}
 
-	return settings;
+	return [...existingSettings.filter(({ id }) => !removedSettingIds.includes(id)), ...newSettings];
 };