Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pnpm 7.29.1 for now to circumvent dep regression #17787

Merged
merged 1 commit into from Mar 14, 2023
Merged

Use pnpm 7.29.1 for now to circumvent dep regression #17787

merged 1 commit into from Mar 14, 2023

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Mar 14, 2023 •
edited

Description

The unit test workflow has started to fail with pnpm@7.29.2.
Seems to be related to pnpm/pnpm#6213.
Therefore we pin the version to 7.29.1 until this issue has been fixed.

Fixes ENG-811

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@paescuj paescuj marked this pull request as ready for review March 14, 2023 11:12
br41nslug
br41nslug approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@br41nslug br41nslug left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems 7.29.2 is still in pre-release with this bug open pnpm/pnpm#5176 and pnpm/pnpm#6213.

Would it be possible to only pull releases and ignore pre-releases? 🤔

@azrikahar azrikahar mentioned this pull request Mar 14, 2023
Merged
9 tasks
@paescuj
Copy link
Member Author

paescuj commented Mar 14, 2023

Seems 7.29.2 is still in pre-release with this bug open pnpm/pnpm#5176 and pnpm/pnpm#6213.

Would it be possible to only pull releases and ignore pre-releases? 🤔

Looks like this has been changed in retrospect. 7.29.2 was released as a normal release.

@paescuj paescuj requested a review from azrikahar March 14, 2023 13:03
@azrikahar azrikahar merged commit 1c7320e into main Mar 14, 2023
@azrikahar azrikahar deleted the pin-pnpm-version branch March 14, 2023 13:30
@licitdev licitdev added this to the Next Release milestone Mar 14, 2023
@paescuj paescuj mentioned this pull request Mar 16, 2023
Merged
9 tasks
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request May 13, 2023
@paescuj @faustro
Use pnpm 7.29.1 for now to circument dep regression (directus#17787)
0485259
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@br41nslug br41nslug br41nslug approved these changes

@licitdev licitdev licitdev approved these changes

@azrikahar azrikahar azrikahar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.23.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paescuj @br41nslug @licitdev @azrikahar