Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of all vitest snapshots #18024

Closed

Conversation

hanneskuettner
Copy link
Contributor

@hanneskuettner hanneskuettner commented Apr 2, 2023

Description

Due to a breaking change in vitest 0.29.0 it now inserts a link to their docs when running the testsuite into snapshot files. This has definitely caused me to add those updated snapshots to a commit by accident before.

Since the pinned vitest version is 0.29.3 I think it is reasonable to update those snapshots. (Done by simply running the test suite).

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:
    Update of test snapshots

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paescuj paescuj enabled auto-merge (squash) April 2, 2023 23:16
@paescuj paescuj requested review from a team, Nitwel, licitdev and jaads and removed request for a team April 2, 2023 23:24
@rijkvanzanten
Copy link
Member

This is also part of #18014

@hanneskuettner
Copy link
Contributor Author

So should I close this and wait for the eventual merge of the Big One?

@rijkvanzanten
Copy link
Member

So should I close this and wait for the eventual merge of the Big One?

Lets give it a minute to see if the other PR is easy enough to merge (the QA might take a while!)

@paescuj
Copy link
Member

paescuj commented Apr 4, 2023

Thanks again for your contribution! We're going to address this via #18014.

@paescuj paescuj closed this Apr 4, 2023
auto-merge was automatically disabled April 4, 2023 18:49

Pull request was closed

@hanneskuettner hanneskuettner deleted the fix/vitest-snapshots branch April 14, 2023 20:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants